Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch response parsing, create safe retry #386

Merged
merged 18 commits into from
Oct 4, 2024
Merged

fix: fetch response parsing, create safe retry #386

merged 18 commits into from
Oct 4, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Oct 3, 2024 •
edited
Loading

Proposed changes

  • update API services to parse error statuses and throw
  • add utf-8 charset, unlikely to be required, but may support decoding issues on middleware
  • add create safe retries
  • updates "creating safe" text at different steps
  • check backup signer exists before continuing to main (stops missing backup wallet alert appearing)
  • added error message notifications during creation (i.e. if retrying)

no real UI changes, will ask @iasonrovis to test rc162

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@truemiller truemiller marked this pull request as ready for review October 4, 2024 09:26
This was linked to issues Oct 4, 2024
Non-checksummed backup address leads to account creation failure #268
Closed
Backup wallet is not added to master Safe #331
Closed
User stuck on "Creating account..." screen for hours (Win & Mac) #340
Open
This was unlinked from issues Oct 4, 2024
Non-checksummed backup address leads to account creation failure #268
Closed
Backup wallet is not added to master Safe #331
Closed
@truemiller truemiller requested review from mohandast52, Tanya-atatakai and iasonrovis and removed request for mohandast52 October 4, 2024 09:37
Tanya-atatakai
Tanya-atatakai approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@Tanya-atatakai Tanya-atatakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with Mohan's comments, but approve in advance

@truemiller
feat: Add delay utility function for retrying API calls
b846c34 
The commit adds a new utility function, `delayInSeconds`, to the `@/utils/delay` module. This function is used in the `SetupCreateSafe` component to introduce a delay of 5 seconds before retrying an API call. The delay is implemented in the error handling logic of the `createSafeWithRetries` function.

Resolves: #123
@truemiller
refactor: constant content-type headers
e0cd316
mohandast52
mohandast52 approved these changes Oct 4, 2024
View reviewed changes
frontend/constants/headers.ts Outdated Show resolved Hide resolved
@truemiller truemiller merged commit a744c2e into staging Oct 4, 2024
4 checks passed
@truemiller truemiller deleted the fix/response-ok-charset branch October 4, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iasonrovis iasonrovis iasonrovis approved these changes

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@mohandast52 mohandast52 mohandast52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User stuck on "Creating account..." screen for hours (Win & Mac)
4 participants
@truemiller @mohandast52 @Tanya-atatakai @iasonrovis